Modify code comment for Worker build_id field #1160 #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #1160 by including language informing users that large codebase may result in long worker startup time when no build_id is given.
|
|
tconley1428
approved these changes
Oct 22, 2025
tconley1428
deleted the
ntk/1160-modify-doc-comment-for-worker-build_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1160 by including language informing users that large codebase may result in long worker startup time when no build_id is given.
What was changed
worker doc comment for build_id field.
Why?
On initialization the best-effort process results in walking and MD5 hashing every module in the codebase, this is normally fast but in large codebases (15M+ lines of code) this can result in a long wait for worker to boot.
Users should have some way to know that providing build_id resolves this issue.
Checklist
Closes Modify code comment for Worker build_id field #1160
How was this tested:
n/a
Any docs updates needed?
n/a